Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode

From: Matthew Garrett
Date: Mon Jul 07 2014 - 12:02:38 EST


On Sat, 2014-07-05 at 13:02 -0600, Bjorn Helgaas wrote:
> > Rafael, Matthew, any comments? We have vacillated on this before and
> > the web is already pretty tangled.
> >
> > Vidya, can you give more details about the bug fixed by this change?
> > What's the scenario? Are we resuming and the device is powered up but
> > ASPM isn't enabled? Maybe you could collect more details in a
> > http://bugzilla.kernel.org report?

I believe that's the case. The proposed change would fix it but isn't
really terribly clean - I think it would be more readable to split this
into multiple functions.

--
Matthew Garrett <matthew.garrett@xxxxxxxxxx>