Re: [PATCH v2 2/2] devicetree: Add Zynq GPIO devicetree bindings documentation

From: SÃren Brinkmann
Date: Mon Jul 07 2014 - 13:35:45 EST


On Mon, 2014-07-07 at 04:53PM +0200, Linus Walleij wrote:
> On Wed, Jun 18, 2014 at 1:39 PM, Harini Katakam <harinik@xxxxxxxxxx> wrote:
>
> > From: Harini Katakam <harini.katakam@xxxxxxxxxx>
> >
> > Add gpio-zynq bindings documentation.
> >
> > Signed-off-by: Harini Katakam <harinik@xxxxxxxxxx>
> > Signed-off-by: Soren Brinkmann <soren.brinkmann@xxxxxxxxxx>
> > ---
> >
> > v2 changes:
> > Improve description.
> (...)
> > +- #gpio-cells : Should be two. First cell is used to mention
> > + pin number.
>
> Don't call this "pin number", call it "GPIO line number".
It's also not mentioning the second cell at all. I'll take the part from
gpio-msm to document this property and replace 'pin' with 'GPIO line'.

SÃren

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/