Re: [PATCH 1/5] memory: add a driver for atmel ram controllers

[Alexandre Belloni]

On 07/07/2014 at 20:33:40 +0200, Jean-Christophe PLAGNIOL-VILLARD wrote :
> > +	if (caps->has_mpddr_clk) {
> > +		clk = devm_clk_get(&pdev->dev, "mpddr");
> > +		if (WARN_ON(IS_ERR(clk)))
> > +			return 0;
> 		I don't like this warn_on this need to be an error

What would you prefer ? pr_err() and panic or BUG_ON ?. We can also
probably simply put a single pr_err(), anyway, the platform will stop
just before switching to userspace.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/