Re: [PATCH v2 2/7] arm64: Support restart through restart notifier call chain

From: Guenter Roeck
Date: Mon Jul 07 2014 - 21:12:33 EST


On 07/07/2014 02:16 PM, Andrew Morton wrote:
On Sun, 6 Jul 2014 16:38:15 -0700 Guenter Roeck <linux@xxxxxxxxxxxx> wrote:

The kernel core now supports a notifier call chain to restart
the system. Call it if arm_pm_restart is not set.

...

--- a/arch/arm64/kernel/process.c
+++ b/arch/arm64/kernel/process.c
@@ -174,6 +174,9 @@ void machine_restart(char *cmd)
/* Now call the architecture specific reboot code. */
if (arm_pm_restart)
arm_pm_restart(reboot_mode, cmd);
+ else
+ blocking_notifier_call_chain(&restart_notifier_list,
+ reboot_mode, cmd);

It would be a bit neater to have a helper function to perform the call,
rather than directly accessing the notifier list. Apart from anything
else, this hides the fact that the core code (presently!) uses the
blocking_ style notifiers.


Introduced kernel_restart_notify (proposals for better names welcome).
As a side effect, moved restart_notifier_list into kernel/reboot.c and
made it static.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/