Re: [PATCH 1/1] ARM: imx: use PTR_ERR_OR_ZERO

[Sachin Kamat]

On Tue, Jul 8, 2014 at 10:49 AM, Shawn Guo <shawn.guo@xxxxxxxxxxxxx> wrote:
> On Tue, Jul 08, 2014 at 09:18:56AM +0530, Sachin Kamat wrote:
>> Hi Shawn,
>>
>> On Mon, Jul 7, 2014 at 11:25 AM, Shawn Guo <shawn.guo@xxxxxxxxxxxxx> wrote:
>> > On Fri, Jul 04, 2014 at 09:03:10PM +0200, Fabian Frederick wrote:
>> >> replace IS_ERR/PTR_ERR
>> >>
>> >> Cc: Shawn Guo <shawn.guo@xxxxxxxxxxxxx>
>> >> Cc: Sascha Hauer <kernel@xxxxxxxxxxxxxx>
>> >> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>> >> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
>> >
>> > Applied, thanks.
>>
>>
>> I had sent a similar series [1] in May which you rejected. Just
>> curious if something
>> changed between then and now?
>
> The main difference is this is the second attempt from a different
> person to "clean up" the code.  I'm still not fond of the change, but
> I'm getting tied to tell people about that, so just applied the change,
> since after all it at least gives some good diffstat.
>
> I would prefer Fabian's patch over yours because it's really good
> enough to have one patch than 5 patches in a series to do the change for
> IMX platform.

Doesn't really matter whose patches are in. I was just curious to know
the change
in logic at this point of time. Thanks for clarification.

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/