Re: [dm-devel] [PATCH] blk-lib: fix error reporting
From: Christoph Hellwig
Date: Tue Jul 08 2014 - 05:50:44 EST
> + if (unlikely(err))
> + ACCESS_ONCE(bb->error) = err;
I can't see a reason for the ACCESS_ONCE here.
Also the likely/unlikely annotations here smell like premature
Otherwise looks good to me.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/