Re: [PATCH 2/2] staging: wlan-ng/hfa384x_usb.c: add blank line after declarations

From: Dan Carpenter
Date: Tue Jul 08 2014 - 06:28:41 EST


On Wed, Jun 25, 2014 at 11:25:33PM +0800, Cheng-Wei Lee wrote:
> This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Quentin Lee <lee.rhapsody@xxxxxxxxx>
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
> b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 07cee56..99e2f2d 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -3533,7 +3533,7 @@ static void hfa384x_usbin_rx(wlandevice_t
> *wlandev, struct sk_buff *skb)
> }
>
> done:
> - return;
> + pr_debug("hfa384x_usbin_rx: done\n");

Don't add this stuff. Just delete the useless label.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/