Re: [PATCH 2/3] gpu: drm: Remove unnecessary parameter from drm_ht_remove_item()

From: Thomas Hellstrom
Date: Tue Jul 08 2014 - 07:40:54 EST

On 07/08/2014 01:24 PM, Daniel Vetter wrote:
> On Tue, Jun 24, 2014 at 10:52:13PM +0100, Masaru Nomura wrote:
>> removed drm_open_hash from drm_ht_remove_item() as the parameter is
>> not used within the function.
>> Signed-off-by: Masaru Nomura <massa.nomura@xxxxxxxxx>
>> ---
>> Please review this patch carefully. The reason the parameter is passed
>> might be some historical one or clarity of which drm_open_hash
>> we remove an item from.
> Reasons for this are probably lost. On the patch:
> Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>

Acked-by: Thomas Hellstrom <thellstrom@xxxxxxxxxx>

> Aside: Imo we could/should just move all the users to directly employ the
> linux hashtab instead of partially reinventing the wheel here in drm.
> -Daniel

Actually, in this case, the wheel was invented in drm before it was made
generic :).
It's possible to utilize part of "hashtable.h" but I don't think the
code size gain
will be major...

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at