Re: [PATCH tip/core/rcu 14/17] rcu: remove CONFIG_PROVE_RCU_DELAY
From: Paul E. McKenney
Date: Tue Jul 08 2014 - 09:56:14 EST
On Tue, Jul 08, 2014 at 10:11:06AM +0200, Paul Bolle wrote:
> Paul,
>
> On Mon, 2014-07-07 at 15:38 -0700, Paul E. McKenney wrote:
> > The CONFIG_PROVE_RCU_DELAY Kconfig parameter doesn't appear to be very
> > effective at finding race conditions, so this commit removes it.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> > Cc: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > ---
> > kernel/rcu/tree.c | 5 -----
> > kernel/rcu/update.c | 3 ---
>
> The commit explanation implies that this patch would also remove the
> entry for PROVE_RCU_DELAY in lib/Kconfig.debug. Is there any reason to
> keep it after this patch?
>
> > tools/testing/selftests/rcutorture/configs/rcu/TREE01 | 1 -
> > tools/testing/selftests/rcutorture/configs/rcu/TREE02 | 1 -
> > tools/testing/selftests/rcutorture/configs/rcu/TREE02-T | 1 -
> > tools/testing/selftests/rcutorture/configs/rcu/TREE03 | 1 -
> > tools/testing/selftests/rcutorture/configs/rcu/TREE04 | 1 -
> > tools/testing/selftests/rcutorture/configs/rcu/TREE05 | 1 -
> > tools/testing/selftests/rcutorture/configs/rcu/TREE06 | 1 -
> > tools/testing/selftests/rcutorture/configs/rcu/TREE07 | 1 -
> > tools/testing/selftests/rcutorture/configs/rcu/TREE08 | 1 -
> > tools/testing/selftests/rcutorture/configs/rcu/TREE08-T | 1 -
> > tools/testing/selftests/rcutorture/configs/rcu/TREE09 | 1 -
> > 13 files changed, 19 deletions(-)
>
> This doesn't touch a few other references in
> tools/testing/selftests/rcutorture/. I have no idea how these tests
> work, so I assume these references are still needed. Is that correct?
Good catch on both counts, fixed.
Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/