Re: [PATCH 2/2] checkpatch: Add ability to insert and delete lines to patch/file

[Andrew Morton]

On Tue, 08 Jul 2014 13:57:44 -0700 Joe Perches <joe@xxxxxxxxxxx> wrote:

> On Tue, 2014-07-08 at 13:24 -0700, Andrew Morton wrote:
> > On Tue,  8 Jul 2014 10:53:36 -0700 Joe Perches <joe@xxxxxxxxxxx> wrote:
> > 
> > > This can be valuable to insert or delete blank lines as well
> > > as fix misplaced brace or else uses.
> > 
> > hm, do we really want to go down this path?
> 
> Maybe, maybe not.
> 
> I've seen a lot of patches that people seem to spend
> time producing (frequently incorrectly done too) that
> could be better automated.
> 
> > It's a very long one and it leads to /usr/bin/indent?
> 
> For now, I think it's a pretty minimal bit of code.

No strong opinions here.

> I've suggested Lindent be removed from the tree.
> https://lkml.org/lkml/2013/2/11/390

Maybe it's fixable, dunno - I don't recall ever seeing anyone get down
and poke at it.  Of course, indent itself is open source...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/