Re: [RFC 2/2] prctl: PR_SET_MM -- Introduce PR_SET_MM_MAP operation

[Andrew Morton]

On Tue, 8 Jul 2014 23:08:49 +0400 Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:

> Ping. Guys, any commens please?

Well, allowing a process to modify pretty deep internals like this is
always scary from a security point of view, and now we're removing
CAP_SYS_RESOURCE protections.  Yikes.  Convince me we aren't handing
out root here.

The changelog doesn't make it clear (to me) why this is actually being
done.  criu runs unprivileged?  What's the requirement here?

struct prctl_mm_map could do with a nice comment explaining its role in
the world.

I'm not seeing a coherent description of the proposed userspace
interface.  We'll eventually want to update the prctl manpage for this,
so how about laying out all the needed details now, at patch review
time so we can see what is proposed.

Why isn't the newly-added code under #ifdef CONFIG_CHECKPOINT_RESTORE?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/