Re: [PATCH 3.2 000/125] 3.2.61-rc1 review

From: Ben Hutchings
Date: Tue Jul 08 2014 - 22:01:36 EST

On Tue, 2014-07-08 at 18:27 -0700, Guenter Roeck wrote:
> Qemu images fail to build for mips, mips64, and x86.
> Build error seems to be always the same.
> lib/nlattr.c: In function 'nla_parse':
> lib/nlattr.c:201:3: error: dereferencing pointer to incomplete type
> make[1]: *** [lib/nlattr.o] Error 1
> Culprit is bfc5184b69 (netlink: rate-limit leftover bytes warning
> and print process name). In 3.2, it is necessary to include <linux/sched.h>
> explicitly to get the definition of 'struct task_struct'.

Thanks - I saw this same regression occurred with 3.4.y, but somehow I
missed what the solution was, and it didn't affect my x86_64 build.
It's odd that the compiler doesn't report the name of the incomplete
type - seems like that would have saved us some time.


> Details are available at
> Guenter

Ben Hutchings
All the simple programs have been written, and all the good names taken.

Attachment: signature.asc
Description: This is a digitally signed message part