Re: [PATCH v3 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

[Greg KH]

On Tue, Jul 08, 2014 at 06:48:18PM -0700, Joe Perches wrote:
> On Tue, 2014-07-08 at 16:45 -0700, Greg KH wrote:
> > On Tue, Jul 08, 2014 at 11:38:30PM +0200, Fabio Falzoi wrote:
> > > Use print_hex_dump_bytes to have memory properly dumped only when
> > > DEBUG is defined.
> []
> > > diff --git a/drivers/staging/rts5208/trace.h b/drivers/staging/rts5208/trace.h
> []
> > > @@ -82,12 +82,11 @@ static inline char *filename(char *path)
> []
> > > +static inline void rtsx_hex_dump(const void *buf, size_t len)
> > > +{
> > > +#ifdef DEBUG
> > > +	print_hex_dump_bytes(KBUILD_MODNAME ": ", DUMP_PREFIX_NONE, buf, len);
> > >  #endif
> > > +}
> > 
> > What a mess.  What's wrong with just using the %*ph modifier in
> > dev_dbg() like other drivers do?
> 
> Dunno.
> Is it ever desired to emit more than 64 bytes of buf?

I doubt it really matters :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/