Re: Re: [PATCHv2 0/8] devfreq: exynos4: Support dt and use common ppmu driver

[Tomeu Vizoso]

On 03/17/2014 02:58 AM, Chanwoo Choi wrote:
> Hi Tomasz,
>
> On 03/15/2014 02:58 AM, Tomasz Figa wrote:
> > However, this driver, even after applying your series, is still far
> > from a state that would allow it to be enabled. The most important
> > issue is direct access to CMU registers, based on static mapping,
> > which is not allowed on multiplatform kernels and
> > multiplatform-awareness for drivers is currently a must.
> >
> > To allow this driver to be enabled, it needs to be converted to use
> > common clock framework functions to configure all clocks, e.g.
> > clk_set_rate(), clk_set_parent(), etc., without accessing CMU
> > registers directly.
> >
> > Of course as long as the driver is effectively unusable, to keep
> > development, we can proceed with refactoring it step-by-step and
> > your series would be basically the first step, after addressing the
> > review comments.
>
> I agree your opinion. When setting frequency of memory bus, this
> driver access directly to CMU registers. I know it should be modified
> by using common clk framework as your comment.
>
> I'll send patch set about using common clk framework instead of CMU
> register based on static mapping after finished the review and apply
> of this patch set as next step.

Hi Chanwoo,

any news on this?

I would love to test this devfreq driver with the clk_set_floor_rate API 
I'm adding to the common clk framework.

Regards,

Tomeu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/