Re: [PATCH tip/core/rcu 2/3] rcu: Add designated reviewers for RCU
From: Joe Perches
Date: Wed Jul 09 2014 - 14:10:34 EST
On Wed, 2014-07-09 at 19:42 +0200, Frederic Weisbecker wrote:
> On Tue, Jul 08, 2014 at 09:09:25PM -0700, Joe Perches wrote:
> > On Tue, 2014-07-08 at 15:25 -0700, Paul E. McKenney wrote:
> > > On Tue, Jul 08, 2014 at 03:05:16PM -0700, Joe Perches wrote:
> > 
> > > > I still think the concept is pretty useless and it's
> > > > just a duplication of "M:", which isn't anything other
> > > > than a list of who should be sent patches.
> > 
> > > It will be interesting to see how things go.
> > Yes, it might work out fine and maybe might cause some
> > other beneficial changes.
> > > There did seem to be
> > > some people who were comfortable being listed as RCU reviewers, but
> > > not as RCU maintainers. Perhaps the same thing happens elsewhere.
> > Maybe so.
> > I wrote a script to find which maintainer addresses that
> > haven't signed or authored a commit in the last 2 years.
> > I got ~250 entries. That's about 1/4 of all maintainer
> > email addresses.
> > Maybe a dozen of these are false positives though because
> > some maintainers prefer to receive email at one address
> > but ack from another.
> > These are all lowercase for better matching.
> Aren't we all falling in the typical pessimism trap, evil of the century!
> Why do we always want to consider the lack of activity from a maintainer as a bad symptom?
> What if it were actually a positive sign resulting of a finished, completed, and perfect
> clean bug-free subsystem?
You mean "free of known defects".
> diff --git a/MAINTAINERS b/MAINTAINERS
> @@ -76,6 +76,9 @@ Descriptions of section entries:
> T: SCM tree type and location.
> Type is one of: git, hg, quilt, stgit, topgit
> S: Status, one of the following:
> + Finished: The code is finished. The maintainer has fixed all
> + the bugs and adressed all missing features. No further
> + patch is needed.
Yeah, some'um like that.
But very few people are capable of writing bug-free,
"finished" code akin to Donald Knuth.
Maybe finding a bug in a section marked like that
should be worth something to the patch submitter.
virtual credit << bugs found
Most of those entries were for the people that
submitted the original code. Most of those too
are no longer active in linux development.
So either put them in the CREDITS file and remove
them altogether from MAINTAINERS or maybe mark them
as reviewers instead of maintainers.
btw: Here's a slightly cleaned up version of the
script I used
$ cat find_active_maintainers.sh
git log --since=2-years-ago | tr [:upper:] [:lower:] > git.commit.log
git grep -E "^M:" MAINTAINERS | tr [:upper:] [:lower:] | cut -d: -f3- | \
sort | uniq | sed -r 's/^\s+//' > maintainer.addresses
cat maintainer.addresses |
while read entry ; do
email=$(echo $entry | sed -r -e 's/^[^<]*<//' -e 's/>.*//')
echo "---> $entry email --> $email"
grep -P "^\s*(?:author:|[\w\-]+by:).*\b$email\b" git.commit.log | \
sed -r -e 's/^\s+//' -e 's/>.*/>/' -e 's/\s+/ /g' | \
sort | uniq -c
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/