Re: [PATCH v9 09/11] seccomp: introduce writer locking
From: Oleg Nesterov
Date: Wed Jul 09 2014 - 14:44:18 EST
On 06/27, Kees Cook wrote:
> static u32 seccomp_run_filters(int syscall)
> - struct seccomp_filter *f;
> + struct seccomp_filter *f = ACCESS_ONCE(current->seccomp.filter);
I am not sure...
This is fine if this ->filter is the 1st (and only) one, in this case
we can rely on rmb() in the caller.
But the new filter can be installed at any moment. Say, right after that
rmb() although this doesn't matter. Either we need smp_read_barrier_depends()
after that, or smp_load_acquire() like the previous version did?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/