RE: [PATCH 2/8] Drivers: scsi: storvsc: Filter commands based on the storage protocol version

[KY Srinivasan]

> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx]
> Sent: Wednesday, July 9, 2014 1:41 AM
> To: KY Srinivasan
> Cc: linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx;
> ohering@xxxxxxxx; jbottomley@xxxxxxxxxxxxx; jasowang@xxxxxxxxxx;
> apw@xxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 2/8] Drivers: scsi: storvsc: Filter commands based on the
> storage protocol version
> 
> On Tue, Jul 08, 2014 at 05:46:46PM -0700, K. Y. Srinivasan wrote:
> > Going forward it is possible that some of the commands that are not
> > currently implemented will be implemented on future Windows hosts.
> > Make command filtering depend on the host version.
> 
> > +	if (vmstor_current_major <= VMSTOR_WIN8_MAJOR) {
> > +		/*
> > +		 * On legacy hosts filter unimplemented commands.
> > +		 */
> > +		if (!storvsc_scsi_cmd_ok(scmnd)) {
> > +			scmnd->scsi_done(scmnd);
> > +			return 0;
> > +		}
> 
> So post-Win8 versions don't need command filering as they can properly
> reject commands they don't understand?  If that's the case please state it in
> the patch description.

I will add the comments you have suggested.

K. Y
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/