RE: [PATCH 3/6] x86-mce: Clear CMCI enable on all claimed CMCI banks before reboot.

From: Luck, Tony
Date: Wed Jul 09 2014 - 16:36:42 EST


+ if (!xchg(&reboot_notifier_registered, true))
+ register_reboot_notifier(&cmci_reboot_notifier);

This is super-safe ... but isn't the xchg() overkill? I thought we serialized bringup
of other cpus.

Has this "do it once" caught on elsewhere in the kernel ... I suppose it is more concise than

if (!reboot_notifier_registered) {
reboot_notifier_registered = 1;
register_reboot_notifier(&cmci_reboot_notifier);
}

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/