Re: [PATCH V8 1/6] power: reset: Add generic SYSCON register mapped reset

[Feng Kan]

On Tue, Jul 8, 2014 at 8:54 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> On 07/08/2014 07:15 PM, Feng Kan wrote:
>>
>> Add a generic SYSCON register mapped reset mechanism.
>>
>> Signed-off-by: Feng Kan <fkan@xxxxxxx>
>> ---
>>   drivers/power/reset/Kconfig         |  6 +++
>>   drivers/power/reset/Makefile        |  1 +
>>   drivers/power/reset/syscon-reboot.c | 91
>> +++++++++++++++++++++++++++++++++++++
>>   3 files changed, 98 insertions(+)
>>   create mode 100644 drivers/power/reset/syscon-reboot.c
>>
>> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
>> index bdcf517..5877b38 100644
>> --- a/drivers/power/reset/Kconfig
>> +++ b/drivers/power/reset/Kconfig
>> @@ -80,3 +80,9 @@ config POWER_RESET_KEYSTONE
>>         help
>>           Reboot support for the KEYSTONE SoCs.
>>
>> +config POWER_RESET_SYSCON
>> +       bool "Generic SYSCON regmap reset driver"
>> +       depends on ARM || ARM64 || COMPILE_TEST
>
>
> As written, this driver is really not generic but very arm specific.
> I don't think COMPILE_TEST is a good idea either, since arm_pm_restart
> is only defined for the arm architecture. Did you try compiling allmodconfig
> or allyesconfig for, say, x86_64 with this patch applied ?
>
> I think this might benefit from using [1], which would make it really
> generic.
>
> Guenter
>
> [1] http://www.spinics.net/lists/kernel/msg1780939.html
This is great, I will base off this list. Did it make it to a branch anywhere?

>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/