Re: [PATCH 3/9] perf, tools: Add support for reading JSON event files v3

[Jiri Olsa]

On Fri, Jun 27, 2014 at 04:15:58PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> 
> Add a parser for Intel style JSON event files. This allows
> to use an Intel event list directly with perf. The Intel
> event lists can be quite large and are too big to store
> in unswappable kernel memory.
> 
> The parser code knows how to convert the JSON fields
> to perf fields. The conversion code is straight forward.
> It knows (very little) Intel specific information, and can be easily
> extended to handle fields for other CPUs.
> 
> The parser code is partially shared with an independent parsing
> library, which is 2-clause BSD licenced. To avoid any conflicts I marked
> those files as BSD licenced too. As part of perf they become GPLv2.

this change breaks compilation, which is probably fixed later on in patchset

  CC       util/jevents.o
util/jevents.c: In function âlookup_msrâ:
util/jevents.c:140:2: error: unknown type name âboolâ
  static bool warned;
  ^
util/jevents.c:148:12: error: âtrueâ undeclared (first use in this function)
   warned = true;
            ^
util/jevents.c:148:12: note: each undeclared identifier is reported only once for each function it appears in
util/jevents.c:149:3: error: implicit declaration of function âpr_errâ [-Werror=implicit-function-declaration]
   pr_err("Unknown MSR in event file %.*s\n",
   ^
util/jevents.c:149:3: error: nested extern declaration of âpr_errâ [-Werror=nested-externs]
cc1: all warnings being treated as errors
make[1]: *** [util/jevents.o] Error 1
make: *** [all] Error 2


jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/