Re: [PATCH net v2] r8169: disable L23
From: David Miller
Date: Wed Jul 09 2014 - 19:42:49 EST
From: Francois Romieu <romieu@xxxxxxxxxxxxx>
Date: Thu, 10 Jul 2014 00:09:54 +0200
> Hayes Wang <hayeswang@xxxxxxxxxxx> :
>> For RTL8411, RTL8111G, RTL8402, RTL8105, and RTL8106, disable the feature
>> of entering the L2/L3 link state of the PCIe. When the nic starts the process
>> of entering the L2/L3 link state and the PCI reset occurs before the work
>> is finished, the work would be queued and continue after the next the PCI
>> reset occurs. This causes the device stays in L2/L3 link state, and the system
>> couldn't find the device.
>>
>> Signed-off-by: Hayes Wang <hayeswang@xxxxxxxxxxx>
>
> Acked-by: Francois Romieu <romieu@xxxxxxxxxxxxx>
>
> Thanks, the explanation of the race between software induced PCI reset
> and transition to PCIe L2/L3 should be clear enough. PM scared me, yet
> it got worse.
>
> Davem, would you mind to s/rtl_l23_enable/rtl_pcie_state_l2l3_enable/ or
> do you want a new patch for it ?
Applied with the function name adjusted, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/