Re: [GIT PULL] ARM: SPEAr1310 PCIe updates
From: Olof Johansson
Date: Thu Jul 10 2014 - 01:17:45 EST
On Wed, Jul 9, 2014 at 5:18 PM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> On 9 July 2014 23:39, Olof Johansson <olof@xxxxxxxxx> wrote:
>> * Why are you sending a pull request for a repo that is not yours?
> Because Mohit/Pratyush were facing some issues in pushing patches
> to the SPEAr public git repo. And so I tried to help them out publicly
> and nobody objected then:
This is completely done wrong on so many levels.
I am not going to merge code from someone who doesn't have the basic
skills down when there's already a maintainer for the platform.
Luckily, you can deal with it -- be it coaching the ST employees on
how to work with the community the right way, or doing the work
yourself to send the code up. Probably a combination in this case.
>> * Why is Viresh the git committer but hasn't signed off on the patches?
> I didn't sign-off because I haven't even looked closed at many of the
> patches around PCI and Acked whatever I could understand.
Thanks, good to know that the series hasn't been fully reviewed. That
makes me even more hesitant to apply it at the moment, given all the
other issues around it.
> But yeah, this committer thing is what I missed. Because of that I might
> be required to signoff it.
Anyone touching the patch, forwarding it or applying it needs to sign
off. It's quite simple, and well documented.
>> Are you sharing accounts on kernel.org? (Adding kernel.org admin on cc
>> just in case).
> Obviously not. I am alone the user of this account.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/