Re: [PATCH] usb: usb5303: make use of uninitialized err variable

From: Geert Uytterhoeven
Date: Thu Jul 10 2014 - 03:38:10 EST

Hi Greg,

On Thu, Jul 10, 2014 at 12:46 AM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Jun 02, 2014 at 07:45:25PM +0200, Emil Goode wrote:
>> The variable err is not initialized here, this patch uses it
>> to store an eventual error value from devm_clk_get().
>> Signed-off-by: Emil Goode <emilgoode@xxxxxxxxx>
>> Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>> ---
>> drivers/usb/misc/usb3503.c | 10 +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)

> This patch fails to apply to my tree :(

You've already applied
commit ec5734c41bee2ee7c938a8f34853d31cada7e67a
Author: Tushar Behera <tushar.b@xxxxxxxxxxx>
Date: Tue Jun 17 16:38:50 2014 +0530

usb: misc: usb3503: Update error code in print message

'err' is uninitialized, rather print the error code directly.

which fixes it slightly different.



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at