Re: [PATCH v7 15/33] net: xen-netback - set name assign type
From: Ian Campbell
Date: Thu Jul 10 2014 - 08:13:53 EST
On Thu, 2014-07-10 at 12:46 +0200, Tom Gundersen wrote:
> On Thu, Jul 10, 2014 at 11:01 AM, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> > On Thu, 2014-07-10 at 10:17 +0200, Tom Gundersen wrote:
> >> The name contains then xen handle, which is not guaranteed to be
> >> stable between restarts, so label this NET_NAME_ENUM.
> > FWIW the N'th interface for domain with domid D will always be named
> > vifD.N.
> > If you reboot domain D then it's domid will change to E and the new
> > device will be vifE.N.
> > I don't know if that counts as predictable as far as the interface you
> > are introducing is concerned.
> That was my understanding, thanks for confirming.
> The idea is that the same interface on the same machine must get the
> same name between reboots in order to be considered predictable. So
> under the assumption that a rebooted domain should be considered "the
> same machine" (i.e., it still has the same local configuration,
> possibly referencing the interface names), then we should consider the
> names not predictable, so NET_NAME_ENUM.
OK, thanks. I'll defer to you understanding of what this interface is
supposed to mean: Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/