Re: [PATCH v7 10/33] net: dummy - set name assign type

[Tom Gundersen]

On Thu, Jul 10, 2014 at 1:44 PM, BjÃrn Mork <bjorn@xxxxxxx> wrote:
> Tom Gundersen <teg@xxxxxxx> writes:
>
>> The result of
>>
>> modprobe dummy numdummies=2
>>
>> is to create dummy0 and dummy1, always with the same names.
>>
>> The result of
>>
>> ip link add type dummy
>>
>> is to create dummyX, where X depends on what came before.
>
> Which is no different. That's exacly what happens when
> "modprobe dummy numdummies=2" creates the two first interfaces.
>
>
>  ip link add link wwan0 name dummy0 type vlan id 2
>  modprobe dummy numdummies=2
>
> ends up with dummy1 and dummy2 created by the dummy driver.
>
> You are trying to make up differences that just aren't there.

Ah, good point. You are right. So the dummy interfaces should be
labelled NET_NAME_ENUM.

I suppose the distinction should be that statically created devices
like these should be NET_NAME_PREDICTABLE only if they fail when the
name they want is already taken (rather than just picking the next
one).

Thanks for looking into this!

Cheers,

Tom
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/