[PATCH 5/9] iommu/amd: Drop pasid_state reference in ppr_notifer error path

From: Joerg Roedel
Date: Thu Jul 10 2014 - 09:29:13 EST

From: Joerg Roedel <jroedel@xxxxxxx>

In case we are not able to allocate a fault structure a
reference to the pasid_state will be leaked. Fix that by
dropping the reference in the error path in case we hold

Signed-off-by: Joerg Roedel <jroedel@xxxxxxx>
Tested-by: Oded Gabbay <Oded.Gabbay@xxxxxxx>
drivers/iommu/amd_iommu_v2.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/iommu/amd_iommu_v2.c b/drivers/iommu/amd_iommu_v2.c
index 574c71b..6ba707b 100644
--- a/drivers/iommu/amd_iommu_v2.c
+++ b/drivers/iommu/amd_iommu_v2.c
@@ -607,6 +607,10 @@ static int ppr_notifier(struct notifier_block *nb, unsigned long e, void *data)
ret = NOTIFY_OK;

+ if (ret != NOTIFY_OK && pasid_state)
+ put_pasid_state(pasid_state);


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/