Re: [PATCH] platform/chrome: pstore: fix dmi table to match all chrome systems

From: Benson Leung
Date: Thu Jul 10 2014 - 13:29:53 EST

On Thu, Jul 10, 2014 at 10:20 AM, Olof Johansson <olof@xxxxxxxxx> wrote:
> Turns out that DMI_SYSTEM_VENDOR is actually the native vendor of each
> Chromebook/box. I tested the original patch on a Pixel that -- surprise,
> has Google as vendor. *facepalm*.
> The only other data I can think of to probe on is Google_* in the version
> string. Checking with our firmware team, all systems should have this
> and nothing else than Chrome hardware should have the coreboot + Google_*
> combination to date.
> So, we'll switch to this. For future platforms we are going to move to
> using an ACPI device to configure this instead of a DMI table (yay!),
> so longer-term that will sort itself out.
> Signed-off-by: Olof Johansson <olof@xxxxxxxxx>

Reviewed-by: Benson Leung <bleung@xxxxxxxxxxxx>

Benson Leung
Software Engineer, Chrom* OS
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at