Re: [RFC PATCH 0/5] workqueue: Introduce low-level unbound wq sysfs cpumask v3
From: Frederic Weisbecker
Date: Fri Jul 11 2014 - 09:12:15 EST
On Fri, Jul 11, 2014 at 04:41:51PM +0800, Lai Jiangshan wrote:
> Hi, Frederic
> I'd like to take this work unless you are still working on it.
> I would do some cleanup at first so that it will be much slow for me.
I was about to iterate again on that patchset but I would certainly be
happy if you take it given the amount of stuff in my TODO list.
I suggest you to take this branch:
It's a big rebase on top of latest -rc1.
Also I suggest you to use "--patience" on git diff/log/format-patch etc...
because the changes contain big code move (like the sysfs part) that default
diff doesn't display well.
I can still help you on this patchset BTW if you need. I believe that
delayed workqueues weren't well handled with it, maybe I should
check further if they need some more treatment.
> On 05/17/2014 12:16 AM, Frederic Weisbecker wrote:
> > So in this version I actually save the cpumask belonging to wq (before
> > it's intersected against the low level cpumask) in its unbounds attrs.
> > But the attrs passed to pwq and worker pools have the low level cpumask
> > computed against the wq cpumask.
> > It makes it easier that way as the wq cpumask itself remains untouched.
> > It's a user setting so it must stay intact. OTOH the cpumask of pwqs and
> > worker pools only belong to the implementation so it's the right
> > place to store the effective cpumask.
> > Also wq_update_unbound_numa() is fixed, and cpu_possible_mask()
> > is restored as a base. Thanks to Lai!
> > Thanks,
> > Frederic
> > git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> > core/workqueue-v5
> > ---
> > Frederic Weisbecker (4):
> > workqueue: Reorder sysfs code
> > workqueue: Create low-level unbound workqueues cpumask
> > workqueue: Split apply attrs code from its locking
> > workqueue: Allow modifying low level unbound workqueue cpumask
> > Lai Jiangshan (1):
> > workqueue: Allow changing attributions of ordered workqueues
> > kernel/workqueue.c | 1674 ++++++++++++++++++++++++++++------------------------
> > 1 file changed, 900 insertions(+), 774 deletions(-)
> > .
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/