Re: [PATCH 2/2] x86_64,signal: Remove 'fs' and 'gs' from sigcontext

[Andi Kleen]

> diff --git a/arch/x86/include/uapi/asm/sigcontext.h b/arch/x86/include/uapi/asm/sigcontext.h
> index 076b11f..df9908b 100644
> --- a/arch/x86/include/uapi/asm/sigcontext.h
> +++ b/arch/x86/include/uapi/asm/sigcontext.h

I don't think renaming fields in uapi/asm is acceptable. These
are likely used by user programs and you'll break compiles.

-Andi

> @@ -177,8 +177,8 @@ struct sigcontext {
>  	__u64 rip;
>  	__u64 eflags;		/* RFLAGS */
>  	__u16 cs;
> -	__u16 gs;
> -	__u16 fs;
> +	__u16 __pad2;		/* Was called gs, but was always zero. */
> +	__u16 __pad1;		/* Was called fs, but was always zero. */
>  	__u16 ss;
>  	__u64 err;
>  	__u64 trapno;

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/