Re: [PATCH 1/1] rcutorture: fixes for printing message buffer
From: Joe Perches
Date: Fri Jul 11 2014 - 17:14:31 EST
On Fri, 2014-07-11 at 17:09 -0400, Pranith Kumar wrote:
> On Fri, Jul 11, 2014 at 4:37 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> > On Fri, 2014-07-11 at 16:30 -0400, Pranith Kumar wrote:
> >> Use snprintf() instead of sprintf() for writing to the message buffer.
> >> Also use vmalloc() for the allocation of the message buffer. Since pr_alert() is
> >> limited to print LOG_LINE_MAX characters at a time, we print the buffer in a
> >> loop one line at a time.
> > Did you see the patch I sent you?
> > https://lkml.org/lkml/2014/6/20/604
> > It doesn't need a vmalloc.
> > What is wrong with that approach?
> I see nothing wrong with what you proposed, but I like having one
> pr_alert instead of lots sprinkled. Also avoiding vmalloc/vfree using
> your approach seems like a win.
Using any alloc an an intermediate buffer for logging
messages is very unusual.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/