Re: [PATCH] reformat_with_checkpatch: Add automation to checkpatch
From: Joe Perches
Date: Sat Jul 12 2014 - 14:29:55 EST
On Sat, 2014-07-12 at 10:55 -0700, Greg KH wrote:
> Yes, the warnings are all due to line-length, but Joe, you shouldn't add
> a patch that causes more checkpatch warnings than before :)
Yeah, that was intentional though.
This script does a series of relatively discrete changes.
Lindent would more or less work, but it's _horrible_ at
wrapping overlong lines and merges all types of changes
For now, people are probably better at line wrapping in
an acceptable way.
> While I always want to see more developers get involved with kernel
> development, there should be a minimum barrier to entry. And that
> barrier is the knowledge of the C language, and knowledge of how to edit
> a text file, and use git. This script takes that barrier away, for
> whitespace cleanups, with not much real use overall.
> So, I'll keep my local copy of this script now, just to have fun with at
> times when I'm bored. But I don't think it should be merged, as-is.
Dunno, I still think it's useful.
Maybe when you get new code, you might run it through a
script like this before committing it.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/