Re: [PATCH] staging: iio: adc: ad7192: fix coding style

From: Jonathan Cameron
Date: Sun Jul 13 2014 - 05:09:58 EST

On 12/07/14 20:16, Marcus Folkesson wrote:
Line over 80 characters. This is for Eudyptula Challenge.

Signed-off-by: Marcus Folkesson <marcus.folkesson@xxxxxxxxx>
Sorry Marcus,

There is a level of trivial cleanup below which it's not worth
taking patches. The 80 character limit is not a hard and fast
rule. Here, if this had been picked up during review of the original
patch, or was fixed as a part of a more substantial series, I'd
have no objection taking it. On it's own it's just too small.


drivers/staging/iio/adc/ad7192.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index 83bb44b..c25c9ab 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -223,7 +223,8 @@ static int ad7192_setup(struct ad7192_state *st,
id &= AD7192_ID_MASK;

if (id != st->devid)
- dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X)\n", id);
+ dev_warn(&st->sd.spi->dev,
+ "device ID query failed (0x%X)\n", id);

switch (pdata->clock_source_sel) {
case AD7192_CLK_EXT_MCLK1_2:

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at