Re: [PATCH 1/1] fs/exofs/ore_raid.c: replace count*size kzalloc by kcalloc

[Boaz Harrosh]

On 06/25/2014 09:14 PM, Fabian Frederick wrote:
> kcalloc manages count*sizeof overflow.
> 
> Cc: Boaz Harrosh <bharrosh@xxxxxxxxxxx>
ACK-by: Boaz Harrosh <bharrosh@xxxxxxxxxxx>

Do you need that I submit this through my tree?

Thanks
Boaz
> Cc: osd-dev@xxxxxxxxxxxx
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
> ---
>  fs/exofs/ore_raid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/exofs/ore_raid.c b/fs/exofs/ore_raid.c
> index 7f20f25..84529b8 100644
> --- a/fs/exofs/ore_raid.c
> +++ b/fs/exofs/ore_raid.c
> @@ -116,7 +116,7 @@ static int _sp2d_alloc(unsigned pages_in_unit, unsigned group_width,
>  			num_a1pa = min_t(unsigned, PAGE_SIZE / sizeof__a1pa,
>  							pages_in_unit - i);
>  
> -			__a1pa = kzalloc(num_a1pa * sizeof__a1pa, GFP_KERNEL);
> +			__a1pa = kcalloc(num_a1pa, sizeof__a1pa, GFP_KERNEL);
>  			if (unlikely(!__a1pa)) {
>  				ORE_DBGMSG("!! Failed to _alloc_1p_arrays=%d\n",
>  					   num_a1pa);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/