Re: [PATCH] cpufreq: Fix latency for cpufreq_info
From: Nick Krause
Date: Mon Jul 14 2014 - 02:25:40 EST
On Mon, Jul 14, 2014 at 2:10 AM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> On 14 July 2014 10:31, Nicholas Krause <xerofoify@xxxxxxxxx> wrote:
>> This fixes the latency for the cpufreq policy to 1 million nanoseconds
>> that calls the function pxa_cpu_init for the member of the structure
>> called cpuinfo.transition_latency.
>> Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>
>> drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
>> index e24269a..e08bb98 100644
>> --- a/drivers/cpufreq/pxa2xx-cpufreq.c
>> +++ b/drivers/cpufreq/pxa2xx-cpufreq.c
>> @@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
>> /* set default policy and cpuinfo */
>> - policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
>> + policy->cpuinfo.transition_latency = 1000, 000;
> Have you tried testing this at all? This patch wouldn't change anything.
> Still 1000 will get assigned to latency :)
> Get rid of the comma.
Sure , sorry about the comma. I am resending this patch to you fixed.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/