Re: [PATCH] xillybus: place 'else' on same line as '}'
From: Dan Carpenter
Date: Mon Jul 14 2014 - 04:52:19 EST
On Mon, Jul 14, 2014 at 09:40:39AM +0300, Eli Billauer wrote:
> Thanks for this.
> And since I looked at the part in Codingstyle that deals with
> if-else, I found another few mistakes regarding braces around a
> single statement. The rules say, it turns out, that if one of the
> clauses in an if-else is longer than one statement, both clauses
> should be wrapped with braces. This rule is broken in lines 162, 536
> and 613 of the same file.
> To avoid possible conflicts, I'll wait for this patch to be applied,
> and submit my corrections after that.
In theory there shouldn't be any need to wait because the rules about
which patches go in first are very clear and predictable. First come
first serve. Unless a patch is rejected. And they are only rejected if
they violate some rule, but normally ok patches go in.
This patch is almost totally ok except it doesn't have "staging" in the
subject. I'm not sure if that's enough to reject it... Probably it's
ok and you should assume it will be merged.
The other reason that you don't need to wait is that this patch won't
conflict with the other patch you are proposing.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/