Re: [PATCH 1/2] net: cadence: macb: add support for the WOL

[Varka Bhadram]

On 07/14/2014 04:19 PM, David Laight wrote:
> From: Varka Bhadram
> > On 07/14/2014 02:32 PM, Jongsung Kim wrote:
> > > This patch enables the ethtool utility to control the WOL function
> > > of the PHY connected to the GEM/MACB. (if supported)
> ...
> > > +static int macb_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
> > > +{
> > > +	struct macb *bp = netdev_priv(netdev);
> > > +	struct phy_device *phydev = bp->phy_dev;
> > > +	int err = -ENODEV;
> > > +
> > > +	if (phydev)
> > > +		err = phy_ethtool_set_wol(phydev, wol);
> > > +
> > > +	return err;
> > > +}
> > > +
> > I think we can do in this way:
> >
> > if (phydev)
> > 	return phy_ethtool_set_wol(phydev, wol);
> > else
> > 	return -ENODEV;
> >
> >
> > we can save err. What do you say ...?
> I would do:
> 	if (!phydev)
> 		return -ENODEV;
> 	return phy_ethtool_set_wol(phydev, wol);

I will agree with this....  :-)

if (!phydev) {
	netdev_err("bla bla...");
	return -ENODEV;
}
return phy_ethtool_set_wol(phydev, wol);



--
Regards,
Varka Bhadram.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/