Re: [PATCH V2 1/4] staging: vt6556: Cleanup coding style issues

[Peter Senna Tschudin]

On Mon, Jul 14, 2014 at 2:58 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Jul 14, 2014 at 10:59:32AM +0200, Peter Senna Tschudin wrote:
>> On Sun, Jul 13, 2014 at 12:36:47PM -0700, Greg KH wrote:
>> > On Sun, Jul 13, 2014 at 09:11:18PM +0200, Peter Senna Tschudin wrote:
>> > > This patch cleanup coding style issues reported by checkpatch.
>> > >
>> > > Tested by compilation only.
>> > >
>> > > Signed-off-by: Peter Senna Tschudin <peter.senna@xxxxxxxxx>
>> > > ---
>> > > Cahnges from V1:
>> > >  - Sent all patches in a series
>> >
>> > Why did you forget the other thing that I asked you to change?
>> >
>> > I can't take these as-is, sorry, please go back and re-read what I
>> > wrote...
>>
>> Actually I was trying to do what you asked me on this E-mail:
>>
>> -- // --
>> You just sent me 4 patches, all with the same subject (but at least 2 of
>> them had the order in which to apply them in, which is nice.)
>>
>> Please redo these such that they have a unique subject, and I can tell
>> which order to apply them in, as I really have no idea about the second
>> two.
>> -- // --
>>
>> I'm sending V3 as a single patch.
>
> That's going to get rejected as well :(
>
> You did put them in a nice order, but you had the same subject text for
> each patch, which I told you not to do, right?
>
> {sigh}
The noise was caused by my poor English language skills. When you wrote:

"Please redo these such that they have a unique subject, and I can tell
which order to apply them in, as I really have no idea about the second
two."

I understood:
 1 - redo these patches
 2 - such as they have a unique subject
 3 - in a way Greg can tell in which order to apply them

I just understood what you wanted today. Sorry for that.

But, there is a plain text attachment on my previous E-mail with the
V3 of the patch set. The V3 is a single patch instead of 4 patches, is
that ok? Should I resend in a new thread?


>
> greg k-h



-- 
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/