Re: [PATCH 1/1 V2] workqueue: remove the del_timer_sync()s in maybe_create_worker()

[Tejun Heo]

Hello,

On Mon, Jul 14, 2014 at 04:13:21PM +0800, Lai Jiangshan wrote:
> It is said in the document that the timer which is being
> deleted by del_timer_sync() should not be restarted:
>   Synchronization rules: Callers must prevent restarting of
>   the timer, otherwise this function is meaningless.
> 
> Repeating timer may cause the del_timer_sync() spin longer,
> or even spin forever in very very very very extreme condition.

I'm fairly sure del_timer_sync() can delete self-requeueing timers.
The implementation busy-waits if the queued timer is the currently
executing one and dequeues only while the timer isn't running which
should be able to handle self-requeueing ones just fine.  Thomas,
del_timer_sync() can reliably delete self-requeueing ones, right?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/