Re: [PATCH 1/3] workqueue: remove the first check and the return value of maybe_create_worker()

From: Tejun Heo
Date: Mon Jul 14 2014 - 10:40:36 EST

On Mon, Jul 14, 2014 at 10:30:11AM +0800, Lai Jiangshan wrote:
> We already have create_worker(). And maybe_create_worker() does not always create worker.

Well, it does unless it fails. Explicit maybe_ there is quite

> maybe_create_worker() may not create worker if the condition is changed after
> it fails at the first time,

It's misleading. Please come up with a different name.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at