Re: [PATCH 1/3] workqueue: remove the first check and the return value of maybe_create_worker()

[Tejun Heo]

On Mon, Jul 14, 2014 at 10:30:11AM +0800, Lai Jiangshan wrote:
> We already have create_worker(). And maybe_create_worker() does not always create worker.

Well, it does unless it fails.  Explicit maybe_ there is quite
misleading.

> maybe_create_worker() may not create worker if the condition is changed after
> it fails at the first time, 

It's misleading.  Please come up with a different name.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/