Re: [PATCH 0/4] New Qualcomm PMIC pin controller drivers

[Ivan T. Ivanov]

On Sat, 2014-07-12 at 16:51 -0700, Bjorn Andersson wrote:
> On Thu, Jul 10, 2014 at 6:39 AM, Ivan T. Ivanov <iivanov@xxxxxxxxxx> wrote:
> > On Wed, 2014-07-09 at 07:02 -0700, Bjorn Andersson wrote:
> [..]
> >> Correct Ivan; we do however share the same issues related to how to do
> >> interrupt handling,
> >
> > Yep, but do we actually need to do interrupt handling in driver?
> > Interrupts are handled by parent device. GPIO client drivers could
> > use interrupt-controller registered by core driver?
> >
> 
> Among other things we have the volume and camera keys hooked to these
> pins, using the gpio-keys driver; so that needs to be able to convert
> a gpio to an irq.
> But I don't believe we should turn this driver into an
> interrupt-controller; as that wouldn't add any value...

I agree. But I would like to avoid specifying 44 "interrupts" in
DT files if they are known a priory in driver for specific chip.

Only drawback that I could see is that it will be little odd for
client drivers, which are using SPMI PMIC pinctrl driver, to specify
4 parameters required by interrupts property.

Regards,
Ivan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/