Re: [PATCH] libata: handle IDE AMNF errors in the EH path

From: Tejun Heo
Date: Mon Jul 14 2014 - 12:10:27 EST


On Sat, Jul 12, 2014 at 12:22:53PM +0400, Alexey Asemov wrote:
> libata-eh.c should handle AMNF error condition (error byte bit 0, usually
> code 0x01) in libata-eh.c along with UNC as a media error so SCSI stack
> can handle it properly (translation code 0x01 is already present in
> libata-scsi.c) but was never passed down due to lack of handling in EH.

IIRC AMNF has been deprecated for a very long time now. The bit isn't
too likely to get reused given that major updates to ATA spec is
improbable but I'm still not quite fond of adding handling of a long
deprecated flag. Can you please provide a bit more detail? Which
device was it?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/