Re: [PATCH 1/1] ARM: dts: zynq: Add Parallella device tree

[Olof Johansson]

On Tue, Jul 8, 2014 at 4:18 AM, Michal Simek <michal.simek@xxxxxxxxxx> wrote:
> On 06/30/2014 07:15 AM, Olof Johansson wrote:
>> Hi,
>>
>> On Sun, Jun 29, 2014 at 1:50 PM, Andreas FÃrber <afaerber@xxxxxxx> wrote:
>>> This allows to boot the Adapteva Parallella board to serial console.
>>>
>>> Cc: Andreas Olofsson <andreas@xxxxxxxxxxxx>
>>> Signed-off-by: Andreas FÃrber <afaerber@xxxxxxx>
>>
>> Nice and clean DTS, just a couple of comments below.
>>
>>> diff --git a/arch/arm/boot/dts/zynq-parallella.dts b/arch/arm/boot/dts/zynq-parallella.dts
>>> new file mode 100644
>>> index 0000000..98df66c
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/zynq-parallella.dts
>>> @@ -0,0 +1,63 @@
>>> +/*
>>> + * Copyright (c) 2014 SUSE LINUX Products GmbH
>>> + *
>>> + * Derived from zynq-zed.dts:
>>> + *
>>> + *  Copyright (C) 2011 Xilinx
>>> + *  Copyright (C) 2012 National Instruments Corp.
>>> + *  Copyright (C) 2013 Xilinx
>>> + *
>>> + * This software is licensed under the terms of the GNU General Public
>>> + * License version 2, as published by the Free Software Foundation, and
>>> + * may be copied, distributed, and modified under those terms.
>>> + *
>>> + * This program is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>> + * GNU General Public License for more details.
>>> + */
>>> +/dts-v1/;
>>> +/include/ "zynq-7000.dtsi"
>>> +
>>> +/ {
>>> +       model = "Parallella Board";

You might want to have this say "Adapteva Parallella Board" instead
(just noticed).

>>> +       compatible = "xlnx,zynq-7000";
>>
>> This should have a more specific compatible as the first one. Probably
>> something like:
>>    compatible = "adapteva,parallella", "xlnx,zynq-7000";
>
> We were using these compatible properties but later there is no reason
> to create them because they will be unused.
> It is easy to add it when you need it which is not this case.

No, please add it from day one, otherwise everybody needs to update
their device tree, some will miss doing it, etc, etc. It's a simple
and trivial thing to do, and no reason to leave it o ut.

>>> +
>>> +       memory {
>>> +               device_type = "memory";
>>> +               reg = <0 0x20000000>;
>>
>> Does the bootloader update this entry, or is it truly static? If it's
>> updated then it's become recent habit to leave the memory size empty
>> in the static file.
>
> Depends on your bootloader. I think it is good to have it here.
> Also this file can be used by u-boot for example and u-boot can be configured
> from it that's why I think that make sense to keep this here.

Ok. It's become commonplace to leave memory empty for the machines
where it's guaranteed that the bootloader will have updated it, to
avoid having stale or incorrect values in the static tree. I'm not
going to be strict about it, but it's something to consider.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/