Re: [PATCH] wireless: fixup genregdb.awk for remove of antenna gain from wireless-regdb

[Luis R. Rodriguez]

On Wed, Jul 2, 2014 at 7:30 AM, John W. Linville <linville@xxxxxxxxxxxxx> wrote:
> On Wed, Jul 02, 2014 at 02:19:36AM +0200, Luis R. Rodriguez wrote:
>> On Tue, Jul 01, 2014 at 04:17:54PM -0400, John W. Linville wrote:
>> > Since "wireless-regdb: remove antenna gain" was merged in the
>> > wireless-regdb tree, this script has been incompatible with the
>> > 'official' regulatory database.  Let's fix it up.
>> >
>> > Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>
>> > ---
>> > I think the dfs_cac stuff is still broken, since it does not account
>> > for the starting offset of the flags.
>>
>> Indeed, but that also breaks other stuff too, because the DFS CAC stuff
>> is optional it means the flags can now start at different locations, it
>> also means that we need to distinguish a flag from a CAC.
>>
>> Here's a complex example we should test for as an example now:
>>
>> country US: DFS-FCC
>>       (2400 - 2450 @ 40), (100 mW)
>>       (2450 - 2500 @ 0), (100 mW), DFS, AUTO-BW
>>       (5170 - 5250 @ 80), (100 mW), DFS, AUTO-BW, NO-OUTDOOR
>>       (5250 - 5330 @ 0), (20), (60000), DFS, AUTO-BW
>>       (5735 - 5835 @ 80), (30)
>>       (57240 - 63720 @ 2160), (40)
>>
>> The changes below seem to address it. I think awk is too fragile to
>
> Your patch looks almost exactly like what I was thinkg to do.

OK I'll resend and update the Kconfig entry to ensure folks are aware
of the issues discussed and our resolution on requiring folks deal
with issue on the awk parser.

>> scale well and keep us sane. A C parser exists but right now it
>> ignores the DFS CAC. Having a parser is nice as it allows us to
>> modify the db.txt on the fly, however parser still requires a bit
>> of an update in code. If we wanted to avoid the parser all together
>> we could just merge a CRDA reader at build time and require a
>> a regulatory.bin file for reading instead of the db.txt. If we
>> had support for that then its really only one step further from
>> having full CRDA functionality upstream on the kernel, ie letting
>> us read the file at run time rather than just build time. If we
>> are to follow the steps from udev with its firmware loader helper
>> we might as well merge CRDA upstream, in fact we could just use
>> request_firmware_direct() for the reader, what remains questionable
>> to me is the signing stuff, but if we already have support module
>> signing checks it doesn't seem far fetched to be able to have
>> request firmware verify a signature on a file, which probably
>> ain't such a bad idea anyway. If we did this we'd have two options:
>>
>> 1) regulatory.bin reader at build time to build the static regulatory domains
>> 2) the same reader code can use request the file at run time via
>>    request_firmware_direct() and if we added signature verification
>>    it can replace CRDA
>>
>> We'd eliminate the ASCII representation completely from the build picture
>> and peg a regulatory.bin firmware to each kernel then. Thoughts?
>
> I'll have to digest this -- needs some more discussion, for sure.

Some more on this. I stumbled upon Takashi Iwai's November 2012
firmware_class Takashi Iwai's signature check series [0] [1]. His
second iteration didn't get merged but there weren't any particular
NACKs on the threads -- upon following up with him it would seem the
way to move this forward though is to integrate this somehow with Kees
Cook's work on LSM. I have yet to do that but at least by looking at
Takashi's patches it would seem moving CRDA functionality upstream is
certainly doable, this would remove both the requirement of CRDA on
userspace and remove any requirement for any build-time parsers on the
kernel. The regulatory format then would move along with the kernel.

The way I'd envision this is we'd enable drivers to pass a
specification of requirements for the firmware, one of which could be
the digital signature check. Another option would be whether or not
the firmware is required or not -- right now we use two different APIs
for this: request_firmware() and request_firmware_direct(), having a
specification could let us unify this into one a bit more cleanly. The
digital signature options then simply become an option for drivers,
and if some distributions do want to force require digital signatures
for all request_firmware() requests it can do so as well through a
Kconfig option.

[0] https://lkml.org/lkml/2012/11/5/467
[1] https://lkml.org/lkml/2012/11/8/343

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/