Re: [PATCH v3 0/2] hwrng, virtio-rng: init-time fixes
From: Herbert Xu
Date: Tue Jul 15 2014 - 00:46:08 EST
On Tue, Jul 15, 2014 at 10:10:28AM +0530, Amit Shah wrote:
> On (Mon) 14 Jul 2014 [20:50:06], Herbert Xu wrote:
> > On Thu, Jul 10, 2014 at 03:42:33PM +0530, Amit Shah wrote:
> > > v3:
> > > - Kees Cook pointed out a weird side-effect: devices which have
> > > ->init() registered get their randomness added to the system each
> > > time they're switched in, but devices that don't have the init
> > > callback don't contribute to system randomness more than once. The
> > > weirdness is resolved here by using the randomness each time
> > > hwrng_init() is attempted, irrespective of the existence of the
> > > device's ->init() callback.
> > All applied to crypto. Thanks!
> Thanks, Herbert. I didn't mention it, but pls queue it up for 3.16.
Yes that's why it's in crypto as opposed to cryptodev.
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/