Re: [PATCH 7/8] staging: dgap: introduce dgap_cleanup_nodes()
From: Dan Carpenter
Date: Tue Jul 15 2014 - 03:57:42 EST
On Tue, Jul 15, 2014 at 04:32:27PM +0900, DaeSeok Youn wrote:
> 2014-07-15 15:41 GMT+09:00 Dan Carpenter <dan.carpenter@xxxxxxxxxx>:
> > On Tue, Jul 15, 2014 at 12:04:02PM +0900, Daeseok Youn wrote:
> >> When a configration file is parsed with dgap_parsefile(),
> >> makes nodes for saving configrations for board.
> >> Making a node will allocate node memory and strings for saving
> >> configrations with kstrdup().
> >> So these are freed when dgap is unloaded or failed to initialize.
> >> Signed-off-by: Daeseok Youn <daeseok.youn@xxxxxxxxx>
> >> ---
> >> It MUST be needed to prevent memory leaks but
> >> I'm not sure that I fix properly.
> >> Please review.
> > This thread doesn't have Mark on the CC list and he's the only person
> > who can actually test it properly. Resend it and CC Mark
> > Hounschell <markh@xxxxxxxxxx>.
> Really? I'd added Mark to CC list.
> hmm.. In your reply doesn't have Mark. I was checking sent-box, he is
> in the CC list.
> OK. I will try to send this again after fixing 6/7 and 8/8.
None of them have Mark CC'd except for the I added him to the reply
about pr_err(). I knew you said you were CC'ing him so I figured
something weird was going on...
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/