[PATCH 1/8 RESEND] staging: dgap: remove redundant error value check

From: Daeseok Youn
Date: Tue Jul 15 2014 - 05:48:35 EST

The retval in dgap_block_til_ready() is initialized to zero,
and if no error has occurred in this function, the retval has a zero.
So it doesn't need to check "retval" itself.

Signed-off-by: Daeseok Youn <daeseok.youn@xxxxxxxxx>
RESEND: Adds Mark to TO list and CC list for checking
send this email properly to him.

drivers/staging/dgap/dgap.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 32988a8..10bd0f2 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -2181,10 +2181,7 @@ static int dgap_block_til_ready(struct tty_struct *tty, struct file *file,

spin_unlock_irqrestore(&ch->ch_lock, lock_flags);

- if (retval)
- return retval;
- return 0;
+ return retval;


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/