Re: [PATCH v3] hwmon: pwm-fan: Add pwm-fan driver

From: Varka Bhadram
Date: Tue Jul 15 2014 - 09:21:11 EST

On 07/15/2014 05:21 PM, Kamil Debski wrote:
The pwm-fan driver enables control of fans connected to PWM lines.
This driver uses the PWM framework, so it is compatible with all
PWM devices that provide drivers through the PWM framework.

Signed-off-by: Kamil Debski <k.debski@xxxxxxxxxxx>
Changes since v2:
- add CONFIG_PM_SLEEP around pwm_fan_suspend and pwm_fan_resume
Changes since v1:
- added documentation to Documentation/hwmon
- fix checkpatch errors
- added extra description to Kconfig
- removed whitespace errors
- include files rearranged to be in alphabetical order
- remove unused sysfs entry pwm1_enable
- changed the behavior of the set_pwm function
- when 0 PWM value is set pwm_disable is run
- pwm_config return value is checked for errors
- use of ATTRIBUTE_GROUPS was added
- removed "Not enouch memory" error message
- fixed probe return value in case of devm_of_pwm_get error
- changed hwmon_device_register_with_groups to
- changes suspend/resume to use pwm_disable/enable
- removed unnecessary CONFIG_PM_SLEEP ifdefs
.../devicetree/bindings/hwmon/pwm-fan.txt | 12 ++
Documentation/hwmon/pwm-fan | 17 ++
drivers/hwmon/Kconfig | 11 ++
drivers/hwmon/Makefile | 1 +
drivers/hwmon/pwm-fan.c | 201 ++++++++++++++++++++
5 files changed, 242 insertions(+)
create mode 100644 Documentation/devicetree/bindings/hwmon/pwm-fan.txt
create mode 100644 Documentation/hwmon/pwm-fan
create mode 100644 drivers/hwmon/pwm-fan.c

diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
new file mode 100644
index 0000000..f534607
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
@@ -0,0 +1,12 @@
+Bindings for a fan connected to the PWM lines
+Required properties:
+- compatible: "pwm-fan"
+- pwms: the PWM that is used to control the PWM fan

It would be more readable if it like this...
Required properties:
- compatible : should be "pwm-fan"
- pwms : The PWM that is used to control the PWM fan

Varka Bhadram.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at