Re: perf: FORMAT_GROUP on attached process stops working in 3.16-rc
From: Peter Zijlstra
Date: Tue Jul 15 2014 - 11:36:12 EST
Subject: perf: Revert ("perf: Always destroy groups on exit")
From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Date: Tue Jul 15 17:27:27 CEST 2014
Vince reported that commit 15a2d4de0eab5 ("perf: Always destroy groups
on exit") causes a regression with grouped events. In particular his
read_group_attached.c test fails.
Because of the context switch optimization in
perf_event_context_sched_out() the 'original' event may end up in the
child process and when that exits the change in the patch in question
destroys the actual grouping.
Therefore revert that change and only destroy inherited groups.
Reported-by: Vince Weaver <vincent.weaver@xxxxxxxxx>
Signed-off-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
kernel/events/core.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
@@ -7458,7 +7458,19 @@ __perf_event_exit_task(struct perf_event
struct perf_event_context *child_ctx,
struct task_struct *child)
- perf_remove_from_context(child_event, true);
+ * Do not destroy the 'original' grouping; because of the context
+ * switch optimization the original events could've ended up in a
+ * random child task.
+ * If we were to destroy the original group, all group related
+ * operations would cease to function properly after this random
+ * child dies.
+ * Do destroy all inherited groups, we don't care about those
+ * and being thorough is better.
+ perf_remove_from_context(child_event, !!child_event->parent);
* It can happen that the parent exits first, and has events
Description: PGP signature