Re: [PATCH 01/13] clk: tegra: Add binding for the Tegra124 DFLL clocksource

From: Mark Brown
Date: Tue Jul 15 2014 - 18:53:33 EST

On Tue, Jul 15, 2014 at 11:23:39PM +0300, Tuomas Tynkkynen wrote:

> That sounds indeed useful for this case. How'd the following interface
> sound for the register offset / selector-to-register-value conversion?
> The I2C address would be a bit trickier to get as it would touch the
> regmap stuff as well, but perhaps it would be a good idea to have a
> phandle to the I2C device itself, and then parse the reg field for
> the address.

This looks fine, can you submit properly please? For the I2C address
why not just have an interface to get the regmap and then provide a way
to get the underlying device back from the regmap?

Attachment: signature.asc
Description: Digital signature