Re: [PATCH V4 4/6] staging: vt6556: Remove typedefs

[Greg KH]

On Tue, Jul 15, 2014 at 10:05:54PM +0200, Peter Senna Tschudin wrote:
> On Tue, Jul 15, 2014 at 5:06 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Mon, Jul 14, 2014 at 09:15:31PM +0200, Peter Senna Tschudin wrote:
> >> This patch removes uneeded typedefs reported by chackpatch and removes
> >> one enum. The removed enum from card.h:
> >>
> >> typedef enum _CARD_PHY_TYPE {
> >>     PHY_TYPE_AUTO = 0,
> >>     PHY_TYPE_11B,
> >>     PHY_TYPE_11G,
> >>     PHY_TYPE_11A
> >> } CARD_PHY_TYPE, *PCARD_PHY_TYPE;
> >
> > Why did you remove this?
> Unlike the other two enums this patch change, this one is not in use.
> As checkpatch complained about the typedef and it is not currently in
> use, I removed it.

Then say that, we want to know _why_ you do something, not _what_ you
do, as it's obvious from the code as to _what_ happens.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/